upd: 编码规范

cutejava/cutejava-system/src/main/resources/mapper/DeptMapper.xml

@@ -1,9 +1,26 @@
 <?xml version="1.0" encoding="UTF-8" ?>
 <!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd" >
 <mapper namespace="cn.odboy.modules.system.mapper.DeptMapper">
-    <select id="findAll" resultType="cn.odboy.model.system.domain.Dept">
+    <resultMap id="BaseResultMap" type="cn.odboy.model.system.domain.Dept">
+        <id column="dept_id" property="id"/>
+        <result column="dept_sort" property="deptSort"/>
+        <result column="name" property="name"/>
+        <result column="enabled" property="enabled"/>
+        <result column="pid" property="pid"/>
+        <result column="sub_count" property="subCount"/>
+        <result column="create_by" property="createBy"/>
+        <result column="update_by" property="updateBy"/>
+        <result column="create_time" property="createTime"/>
+        <result column="update_time" property="updateTime"/>
+    </resultMap>
+
+    <sql id="BaseResultMap">
+        dept_id, name, pid, sub_count, create_time, update_time, create_by, update_by, enabled, dept_sort
+    </sql>
+
+    <select id="findAll" resultMap="BaseResultMap">
         select
-        *
+        <include refid="BaseResultMap"/>
         from sys_dept
         <where>
             <if test="criteria.ids != null and criteria.ids.size() > 0">
@@ -31,34 +48,23 @@
         order by dept_sort
     </select>
 
-    <select id="findByPid" resultType="cn.odboy.model.system.domain.Dept">
+    <select id="findByPid" resultMap="BaseResultMap">
         select
-        *
+        <include refid="BaseResultMap"/>
         from sys_dept
         where pid = #{pid}
     </select>
 
-    <select id="findByPidIsNull" resultType="cn.odboy.model.system.domain.Dept">
+    <select id="findByPidIsNull" resultMap="BaseResultMap">
         select
-       *
+        <include refid="BaseResultMap"/>
         from sys_dept
         where pid is null
     </select>
 
     <select id="findByRoleId" resultType="cn.odboy.model.system.domain.Dept">
-        select d.dept_id as id,
+        select d.dept_id as id, d.name, d.pid, d.sub_count, d.create_time, d.update_time, d.create_by, d.update_by, d.enabled, d.dept_sort
-               d.name,
+        from sys_dept d, sys_roles_depts r
-               d.pid,
+        where d.dept_id = r.dept_id and r.role_id = #{roleId}
-               d.sub_count,
-               d.create_time,
-               d.update_time,
-               d.create_by,
-               d.update_by,
-               d.enabled,
-               d.dept_sort
-        from sys_dept d,
-             sys_roles_depts r
-        where d.dept_id = r.dept_id
-          and r.role_id = #{roleId}
     </select>
 </mapper>

cutejava/cutejava-system/src/main/resources/mapper/MenuMapper.xml

@@ -1,9 +1,34 @@
 <?xml version="1.0" encoding="UTF-8" ?>
 <!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd" >
 <mapper namespace="cn.odboy.modules.system.mapper.MenuMapper">
-    <select id="findAll" resultType="cn.odboy.model.system.domain.Menu">
+    <resultMap id="BaseResultMap" type="cn.odboy.model.system.domain.Menu">
+        <id column="menu_id" property="id"/>
+        <result column="title" property="title"/>
+        <result column="name" property="componentName"/>
+        <result column="menu_sort" property="menuSort"/>
+        <result column="component" property="component"/>
+        <result column="path" property="path"/>
+        <result column="type" property="type"/>
+        <result column="permission" property="permission"/>
+        <result column="icon" property="icon"/>
+        <result column="cache" property="cache"/>
+        <result column="hidden" property="hidden"/>
+        <result column="pid" property="pid"/>
+        <result column="sub_count" property="subCount"/>
+        <result column="i_frame" property="iFrame"/>
+        <result column="create_by" property="createBy"/>
+        <result column="update_by" property="updateBy"/>
+        <result column="create_time" property="createTime"/>
+        <result column="update_time" property="updateTime"/>
+    </resultMap>
+
+    <sql id="Base_Column_List">
+        menu_id, title, name, menu_sort, component, path, type, permission, icon, cache, hidden, pid, sub_count, i_frame, create_by, update_by, create_time, update_time
+    </sql>
+
+    <select id="findAll" resultMap="BaseResultMap">
         select
-        *
+        <include refid="Base_Column_List"/>
         from sys_menu
         <where>
             <if test="criteria.blurry != null and criteria.blurry != ''">
@@ -26,7 +51,7 @@
         order by menu_sort
     </select>
 
-    <select id="findByRoleIdsAndTypeNot" resultType="cn.odboy.model.system.domain.Menu">
+    <select id="findByRoleIdsAndTypeNot" resultMap="BaseResultMap">
         SELECT m.* FROM sys_menu m, sys_roles_menus r
         WHERE m.menu_id = r.menu_id AND r.role_id IN
         <foreach collection="roleIds" item="roleId" open="(" separator="," close=")">
@@ -36,16 +61,17 @@
         order by m.menu_sort
     </select>
 
-    <select id="findByPidOrderByMenuSort" resultType="cn.odboy.model.system.domain.Menu">
+    <select id="findByPidOrderByMenuSort" resultMap="BaseResultMap">
         SELECT
-       *
+        <include refid="Base_Column_List"/>
         from sys_menu
         WHERE pid = #{pid}
         ORDER BY menu_sort
     </select>
 
-    <select id="findByPidIsNullOrderByMenuSort" resultType="cn.odboy.model.system.domain.Menu">
+    <select id="findByPidIsNullOrderByMenuSort" resultMap="BaseResultMap">
-        SELECT *
+        SELECT
+        <include refid="Base_Column_List"/>
         from sys_menu
         where pid is null
         order by menu_sort

cutejava/cutejava-system/src/main/resources/mapper/RoleDeptMapper.xml

@@ -11,8 +11,7 @@
     </insert>
 
     <delete id="deleteByRoleId">
-        delete
+        delete from sys_roles_depts
-        from sys_roles_depts
         where role_id = #{roleId}
     </delete>
 

cutejava/cutejava-system/src/main/resources/mapper/RoleMapper.xml

@@ -23,26 +23,17 @@
     </resultMap>
 
     <sql id="Base_Column_List">
-        role
+        role.role_id as role_role_id, role.name as role_name, role.data_scope as role_data_scope,
-        .
-        role_id
-        as role_role_id, role.name as role_name, role.data_scope as role_data_scope,
         role.level as role_level, role.description as role_description, role.create_by as role_create_by,
         role.update_by as role_update_by, role.create_time as role_create_time, role.update_time as role_update_time
     </sql>
 
     <sql id="Menu_Column_List">
-        menu
+        menu.menu_id as menu_id, menu.title as menu_title, menu.permission as menu_permission
-        .
-        menu_id
-        as menu_id, menu.title as menu_title, menu.permission as menu_permission
     </sql>
 
     <sql id="Dept_Column_List">
-        dept
+        dept.dept_id as dept_id, dept.name as dept_name
-        .
-        dept_id
-        as dept_id, dept.name as dept_name
     </sql>
 
     <sql id="Where_sql">
@@ -61,8 +52,7 @@
 
     <select id="queryAll" resultType="cn.odboy.model.system.domain.Role">
         select role_id as id, name, level
-        from sys_role
+        from sys_role order by level
-        order by level
     </select>
 
     <select id="findAll" resultMap="BaseResultMap">
@@ -93,8 +83,7 @@
     </select>
 
     <select id="findByName" resultType="cn.odboy.model.system.domain.Role">
-        select role_id as id
+        select role_id as id from sys_role
-        from sys_role
         where name = #{name}
     </select>
 

cutejava/cutejava-system/src/main/resources/mapper/RoleMenuMapper.xml

@@ -11,8 +11,7 @@
     </insert>
 
     <delete id="deleteByRoleId">
-        delete
+        delete from sys_roles_menus
-        from sys_roles_menus
         where role_id = #{roleId}
     </delete>
 
@@ -25,8 +24,7 @@
     </delete>
 
     <delete id="deleteByMenuId">
-        delete
+        delete from sys_roles_menus
-        from sys_roles_menus
         where menu_id = #{menuId}
     </delete>
 </mapper>

cutejava/cutejava-system/src/main/resources/mapper/UserJobMapper.xml

@@ -11,8 +11,7 @@
     </insert>
 
     <delete id="deleteByUserId">
-        delete
+        delete from sys_users_jobs
-        from sys_users_jobs
         where user_id = #{userId}
     </delete>
 

cutejava/cutejava-system/src/main/resources/mapper/UserMapper.xml

@@ -24,7 +24,7 @@
             <result column="dept_name" property="name"/>
         </association>
         <collection property="jobs" ofType="cn.odboy.model.system.domain.Job">
-            <id column="id" property="id"/>
+            <id column="job_id" property="id"/>
             <result column="job_name" property="name"/>
         </collection>
         <collection property="roles" ofType="cn.odboy.model.system.domain.Role">
@@ -36,10 +36,7 @@
     </resultMap>
 
     <sql id="Base_Column_List">
-        u
+        u.user_id as user_user_id, u.dept_id as user_dept_id, u.username as user_username,
-        .
-        user_id
-        as user_user_id, u.dept_id as user_dept_id, u.username as user_username,
            u.nick_name as user_nick_name, u.email as user_email, u.phone as user_phone,
            u.gender as user_gender, u.avatar_name as user_avatar_name, u.avatar_path as user_avatar_path,
            u.enabled as user_enabled, u.pwd_reset_time as user_pwd_reset_time, u.create_by as user_create_by,
@@ -48,19 +45,14 @@
     </sql>
 
     <sql id="Job_Column_List">
-        j
+        j.job_id as job_id, j.name as job_name
-        .
-        id, j.name as job_name
     </sql>
 
     <sql id="Role_Column_List">
-        r
+        r.role_id as role_id, r.name as role_name, r.level as role_level, r.data_scope as role_data_scope
-        .
-        role_id
-        as role_id, r.name as role_name, r.level as role_level, r.data_scope as role_data_scope
     </sql>
 
-    <sql id="WHERE_SQL">
+    <sql id="Whrer_Sql">
         <where>
             <if test="criteria.id != null">
                 and u.user_id = #{criteria.id}
@@ -96,14 +88,14 @@
         <include refid="Base_Column_List"/>
         from sys_user u
         left join sys_dept d on u.dept_id = d.dept_id
-        <include refid="WHERE_SQL"/>
+        <include refid="Whrer_Sql"/>
         order by u.user_id desc
         <if test="criteria.offset != null">
             limit #{criteria.offset}, #{criteria.size}
         </if>
         ) u
         left join sys_users_jobs suj on u.user_user_id = suj.user_id
-        left join sys_job j on suj.job_id = j.id
+        left join sys_job j on suj.job_id = j.job_id
         left join sys_users_roles sur on u.user_user_id = sur.user_id
         left join sys_role r on sur.role_id = r.role_id
         order by u.user_user_id desc
@@ -112,7 +104,7 @@
     <select id="countAll" resultType="java.lang.Long">
         select count(*)
         from sys_user u
-        <include refid="WHERE_SQL"/>
+        <include refid="Whrer_Sql"/>
     </select>
 
     <select id="findByUsername" resultMap="BaseResultMap">
@@ -125,45 +117,30 @@
     </select>
 
     <select id="findByEmail" resultType="cn.odboy.model.system.domain.User">
-        select user_id as id, username
+        select user_id as id, username from sys_user
-        from sys_user
         where email = #{email}
     </select>
 
     <select id="findByPhone" resultType="cn.odboy.model.system.domain.User">
-        select user_id as id, username
+        select user_id as id, username from sys_user
-        from sys_user
         where phone = #{phone}
     </select>
 
     <select id="findByRoleId" resultType="cn.odboy.model.system.domain.User">
-        SELECT u.user_id as id, u.username
+        SELECT u.user_id as id, u.username FROM sys_user u, sys_users_roles r
-        FROM sys_user u,
+        WHERE u.user_id = r.user_id AND r.role_id = #{roleId}
-             sys_users_roles r
-        WHERE u.user_id = r.user_id
-          AND r.role_id = #{roleId}
         group by u.user_id
     </select>
 
     <select id="findByRoleDeptId" resultType="cn.odboy.model.system.domain.User">
-        SELECT u.*
+        SELECT u.* FROM sys_user u, sys_users_roles r, sys_roles_depts d
-        FROM sys_user u,
+        WHERE u.user_id = r.user_id AND r.role_id = d.role_id AND d.dept_id = #{deptId}
-             sys_users_roles r,
-             sys_roles_depts d
-        WHERE u.user_id = r.user_id
-          AND r.role_id = d.role_id
-          AND d.dept_id = #{deptId}
         group by u.user_id
     </select>
 
     <select id="findByMenuId" resultType="cn.odboy.model.system.domain.User">
-        SELECT u.user_id as id, u.username
+        SELECT u.user_id as id, u.username FROM sys_user u, sys_users_roles ur, sys_roles_menus rm
-        FROM sys_user u,
+        WHERE u.user_id = ur.user_id AND ur.role_id = rm.role_id AND rm.menu_id = #{menuId}
-             sys_users_roles ur,
-             sys_roles_menus rm
-        WHERE u.user_id = ur.user_id
-          AND ur.role_id = rm.role_id
-          AND rm.menu_id = #{menuId}
         group by u.user_id
     </select>
 

cutejava/cutejava-system/src/main/resources/mapper/UserRoleMapper.xml

@@ -11,8 +11,7 @@
     </insert>
 
     <delete id="deleteByUserId">
-        delete
+        delete from sys_users_roles
-        from sys_users_roles
         where user_id = #{userId}
     </delete>